[SEDONA-511] Fix reading/writing geoparquet metadata for snake_case or camelCase column names #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
approved these changes
Mar 6, 2024
jiayuasu
pushed a commit
that referenced
this pull request
Apr 28, 2024
…r camelCase column names (#1270) * Fix geoparquet metadata for snake_case and camelCase geometry column names * Apply the change to Spark 3.4 and 3.5 * Fix binary compatibility issue for Spark 3.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
The current GeoParquet implementation converts the geo metadata to camel or underscore style during parsing and serialization, and it introduces consistency issues with the schema of the parquet files. This patch resolves this issue by skipping the style conversion for column names. Now it should work correctly with geometry column names such as
geom_columnorgeomColumn.How was this patch tested?
Added tests for geoparquet and geoparquet.metadata data source.
Did this PR include necessary documentation updates?