Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-559] Make the flink example work #1420

Merged
merged 6 commits into from
May 29, 2024
Merged

Conversation

docete
Copy link
Contributor

@docete docete commented May 21, 2024

The sedona examples project is not managed by parent pom file.
It should be a submodule of the parent project and the flink example should work in IDE.
This PR fix this.

What changes were proposed in this PR?

  • b24e17d enable scalastyle config
  • 84ae117 make the flink example work

How was this patch tested?

@jiayuasu
Copy link
Member

@docete Sorry, the example projects are not included in the parent pom on purpose. They are not considered as source code of Sedona. They are templates for people to develop their own applications.

@docete
Copy link
Contributor Author

docete commented May 22, 2024

@jiayuasu IMO it should be included in the parent pom if it is placed in the same repo. Otherwise, it will not be well maintained. BTW, we should implement our use cases as the formal demonstration. What do you think?

@jiayuasu
Copy link
Member

The purpose of the example projects is to demo that you can build applications on top of the released version of Sedona. This is also useful for us to discover dependency bugs which cannot be discovered when bundled together with the parent pom.

We also have CI/CD to test the correctness of the example projects.

@docete
Copy link
Contributor Author

docete commented May 23, 2024

OK, I will unbundle the example projects and fix the build/run issues.

@docete
Copy link
Contributor Author

docete commented May 24, 2024

Check the ci/cd issues
[INFO] ------------------------------------------------------------------------ Error: Unable to access jarfile target/sedona-spark-example-1.0.0.jar Error: Process completed with exit code 1.
Should we keep the example version and the sedona version consistent?

@jiayuasu
Copy link
Member

We could but we don't have to. What is your preference?

@docete
Copy link
Contributor Author

docete commented May 24, 2024

Let it consistent with SEDONA parent to keep it up to date with every release.

@jiayuasu
Copy link
Member

sounds good!

@docete
Copy link
Contributor Author

docete commented May 27, 2024

updated the github ci/cd script.

examples/pom.xml Outdated Show resolved Hide resolved
@jiayuasu jiayuasu merged commit ee74206 into apache:master May 29, 2024
53 checks passed
@docete docete deleted the SEDONA-559 branch May 29, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants