read Shapefiles by Multiple Partitions #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SW186000 The newly added test case failed. Please fix it. |
SW186000
changed the title
|
@SW186000 Is this ready to be merged? |
|
It's ok. |
jiayuasu
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this PR related to a proposed Issue?
#356
What changes were proposed in this PR?
before only one combinefilesplits exists in shapefileInputFormat
so that split combinefilesplits into several filename types
How was this patch tested?
yes and add test data (map.shp is splited into two files in multipleshapefiles)
Did this PR include necessary documentation updates?
yes