Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial parttioning full support python #448

Merged
merged 33 commits into from
Jun 6, 2020
Merged

Spatial parttioning full support python #448

merged 33 commits into from
Jun 6, 2020

Conversation

Imbruced
Copy link
Member

@Imbruced Imbruced commented Jun 1, 2020

Is this PR related to a proposed Issue?

#447

What changes were proposed in this PR?

Add support for partition number in spatialPartitioning function

How was this patch tested?

1 additional python test
test_spatial_partitioning_with_number_of_partitions

Did this PR include necessary documentation updates?

No

Bring back mvn clean install instead of mvn -q clean install -DskipTests whic was used to speed up tests.
-q missing flag was causing issue with to much verbosity.
Remove testing Spark 2.3 with Python, there is tests only for Python 3.7 and Spark 2.4.
The update was caused by package name change.
Copy link
Member

@jiayuasu jiayuasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GeoSpark 1.3.2 is not released yet. Should we include binary files here?

@Imbruced
Copy link
Member Author

Imbruced commented Jun 3, 2020

I am adding them for easier installing Python package. We can remove them and stay with the code only, and official wheel files we will publish on PyPi only.

@jiayuasu jiayuasu added this to the 1.3.2 milestone Jun 6, 2020
@jiayuasu jiayuasu merged commit 17a5d82 into apache:master Jun 6, 2020
scially added a commit to scially/GeoSpark that referenced this pull request Jun 8, 2020
Spatial parttioning full support python (apache#448)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants