Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ST_NumGeometries #460

Merged
merged 7 commits into from
Jun 29, 2020
Merged

Conversation

imdany
Copy link
Contributor

@imdany imdany commented Jun 20, 2020

Is this PR related to a proposed Issue?

Implement complete SQL/MM and PostGIS functions in GeoSparkSQL

What changes were proposed in this PR?

Added ST_NumGeometries.

Returns the number of Geometries. If geometry is a GEOMETRYCOLLECTION (or MULTI*) return the number of geometries, for single geometries will return 1.

How was this patch tested?

Unit Testing and Jar tested in Databricks environment

Did this PR include necessary documentation updates?

Yes.

@Imbruced
Copy link
Member

@jiayuasu can you look on this ?

Copy link
Member

@jiayuasu jiayuasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

imdany added a commit to imdany/GeoSpark that referenced this pull request Jun 26, 2020
@jiayuasu
Copy link
Member

@imdany Please fix this as well. Thank you very much!

jiayuasu pushed a commit that referenced this pull request Jun 29, 2020
* Added LineMerge function for adding Multilinestrings together

* Added LineMerge function to catalog

* Added LineMerge function tests

* Added LineMerge function documentation

* Changed test as commented in PR #460

* Typo

* Fixed mismatched bracket

* Added "Since" in documentation
@jiayuasu
Copy link
Member

@imdany Unfortunately, the git conflict appears again. Could you please fix it?

@jiayuasu jiayuasu merged commit c3a5f4f into apache:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants