-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ST_NumGeometries #460
Merged
Merged
Add ST_NumGeometries #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imbruced
requested changes
Jun 24, 2020
sql/src/test/scala/org/datasyslab/geosparksql/functionTestScala.scala
Outdated
Show resolved
Hide resolved
sql/src/test/scala/org/datasyslab/geosparksql/functionTestScala.scala
Outdated
Show resolved
Hide resolved
sql/src/test/scala/org/datasyslab/geosparksql/functionTestScala.scala
Outdated
Show resolved
Hide resolved
sql/src/test/scala/org/datasyslab/geosparksql/functionTestScala.scala
Outdated
Show resolved
Hide resolved
@jiayuasu can you look on this ? |
jiayuasu
approved these changes
Jun 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
imdany
added a commit
to imdany/GeoSpark
that referenced
this pull request
Jun 26, 2020
@imdany Please fix this as well. Thank you very much! |
jiayuasu
pushed a commit
that referenced
this pull request
Jun 29, 2020
* Added LineMerge function for adding Multilinestrings together * Added LineMerge function to catalog * Added LineMerge function tests * Added LineMerge function documentation * Changed test as commented in PR #460 * Typo * Fixed mismatched bracket * Added "Since" in documentation
@imdany Unfortunately, the git conflict appears again. Could you please fix it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this PR related to a proposed Issue?
Implement complete SQL/MM and PostGIS functions in GeoSparkSQL
What changes were proposed in this PR?
Added ST_NumGeometries.
Returns the number of Geometries. If geometry is a GEOMETRYCOLLECTION (or MULTI*) return the number of geometries, for single geometries will return 1.
How was this patch tested?
Unit Testing and Jar tested in Databricks environment
Did this PR include necessary documentation updates?
Yes.