[SEDONA-200] Add ST_CoordDim to Sedona #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@furqaankhan Please fix the git conflicts. |
|
@furqaankhan Please fix the failed CI |
jiayuasu
requested changes
Jul 10, 2023
flink/src/main/java/org/apache/sedona/flink/expressions/Functions.java
Outdated
Show resolved
Hide resolved
| @@ -893,6 +902,7 @@ public static class ST_Degrees extends ScalarFunction { | |||
| @DataTypeHint("Double") | |||
| public Double eval(@DataTypeHint("Double") Double angleInRadian) { | |||
| return org.apache.sedona.common.Functions.degrees(angleInRadian); | |||
|
|
|||
There was a problem hiding this comment.
Please do not make changes to irrelevant parts of the codebase
core/src/main/java/org/apache/sedona/core/spatialOperator/JoinQuery.java
Show resolved
Hide resolved
sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/st_functions.scala
Show resolved
Hide resolved
jiayuasu
requested changes
Jul 11, 2023
sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/st_functions.scala
Show resolved
Hide resolved
jiayuasu
approved these changes
Jul 12, 2023
|
@furqaankhan Please fix the failed CI |
jiayuasu
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?