Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-370] Remove the old GeoTiff reader #980

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Conversation

jiayuasu
Copy link
Member

@jiayuasu jiayuasu commented Aug 20, 2023

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

Dropped the following functions and removed their docs. These functions are buggy and not well designed

  1. sedona.read.format("geotiff")
  2. sedona.write.format("geotiff")
  3. RS_GetBand()
  4. RS_Append()
  5. The corresponding readers and writers in Sedona R must also be dropped.

Deleted the docs of the following function as they will no longer work without the old geotiff reader and writer. They will be re-implemented in another PR

  1. RS_HTML
  2. RS_Base64

How was this patch tested?

Passed unit tests

Did this PR include necessary documentation updates?

  • Yes, I have updated the documentation update.

@jiayuasu jiayuasu added this to the sedona-1.5.0 milestone Aug 20, 2023
@jiayuasu jiayuasu merged commit 9c585f0 into master Aug 20, 2023
39 checks passed
@jiayuasu jiayuasu deleted the drop-old-geotiff-reader branch August 20, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant