[SEDONA-376] Add RS_SetValues #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
requested changes
Aug 26, 2023
docs/api/sql/Raster-operators.md
Outdated
| ```sql | ||
| SELECT RS_BandAsArray( | ||
| RS_SetValues( | ||
| RS_AddBandAsArray( |
There was a problem hiding this comment.
This should be RS_AddBandFromArray
| return setValues(raster, band, colX, rowY, width, height, values, false); | ||
| } | ||
|
|
||
| private static void ensureBand(GridCoverage2D raster, int band) throws IllegalArgumentException { |
There was a problem hiding this comment.
Isn't this ensureBand function implemented at several places? If so, we need to share it across functions.
There was a problem hiding this comment.
Sure! I will make one implementation public and use that.
docs/api/sql/Raster-operators.md
Outdated
| @@ -963,6 +963,47 @@ Output: | |||
| -3.000000 | |||
| ``` | |||
|
|
|||
| ### RS_SetValues | |||
|
|
|||
| Introduction: Returns raster with new values for specified pixels for designated band. | |||
There was a problem hiding this comment.
Please clearly explain how this setValue works. It should cover the region specified by the min point from colX and rowY.
jiayuasu
requested changes
Aug 26, 2023
| * @throws IllegalArgumentException | ||
| */ | ||
| public static void ensureBand(GridCoverage2D raster, int band) throws IllegalArgumentException { | ||
| if (band > RasterAccessors.numBands(raster)) { |
There was a problem hiding this comment.
This should also check if the band is 1-indexed, e.g., band cannot < 1
| for (int j = rowY; j < rowY + height; j++) { | ||
| for (int i = colX; i < colX + width; i++) { | ||
| double[] pixel = rasterCopied.getPixel(i, j, (double[]) null); | ||
| if (keepNoData && noDataValue != pixel[band - 1]) { |
There was a problem hiding this comment.
A better implementation of this if condition is
if (keepNoData && noDataValue == pixel[band-1]) {
continue;
}
else pixel[band-1] = values[iterator]
jiayuasu
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?