[SEDONA-379] Add RS_Base64 #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
requested changes
Aug 31, 2023
| @@ -470,6 +470,12 @@ class rasteralgebraTest extends TestBaseScala with BeforeAndAfter with GivenWhen | |||
| assert(writtenBinary1.length > writtenBinary2.length) | |||
| } | |||
|
|
|||
| it("Passed RS_Base64") { | |||
There was a problem hiding this comment.
This is not a correct output of Base64. I believe it should start with "data:PNG". Please double check.
docs/api/sql/Raster-writer.md
Outdated
| Output: | ||
|
|
||
| ``` | ||
| iVBORw0KGgoAAAA... |
| @@ -101,4 +104,11 @@ public static byte[] asArcGrid(GridCoverage2D raster, int sourceBand) { | |||
| public static byte[] asArcGrid(GridCoverage2D raster) { | |||
| return asArcGrid(raster, -1); | |||
| } | |||
|
|
|||
| public static String asBase64(GridCoverage2D raster) throws IOException { | |||
There was a problem hiding this comment.
Please add a test in Sedona-common to test it.
There was a problem hiding this comment.
BTW, I am adding tests for the other outputs as well. Don't merge rn.
There was a problem hiding this comment.
arc grid test is very slow, I didn't include it. You may merge.
jiayuasu
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?