Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-382] Merge SQL and core to a single Spark module #997

Merged
merged 4 commits into from
Sep 5, 2023

Conversation

jiayuasu
Copy link
Member

@jiayuasu jiayuasu commented Sep 4, 2023

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

  1. Merge SQL and core modules to a single spark module.
  2. Update the test resource paths used in all other modules

How was this patch tested?

Passed existing unit tests

Did this PR include necessary documentation updates?

A follow-up PR will fix the docs once all tickets under SEDONA-380 are addressed.

@jiayuasu
Copy link
Member Author

jiayuasu commented Sep 5, 2023

@gregleleu Do you have time to take a look at this? The R tests are failing again saying that hadoop_version has multiple arguments. But this PR didn't seem to change anything except the path of the test data.

Thank you very much!

@jiayuasu
Copy link
Member Author

jiayuasu commented Sep 5, 2023

@gregleleu no worries. I have fixed this by removing the hadoop_version

@jiayuasu jiayuasu merged commit ad16e38 into master Sep 5, 2023
39 checks passed
@jiayuasu jiayuasu deleted the merge-sql-to-core branch September 22, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant