SCB-156 minor improve

Signed-off-by: zhengyangyong <yangyong.zheng@huawei.com>
apache · Jan 3, 2018 · d80c07d · d80c07d
1 parent f888e8d
commit d80c07d
Showing 1 changed file with 10 additions and 11 deletions.
diff --git a/.../springmvc-client/src/main/java/io/servicecomb/demo/springmvc/client/SpringmvcClient.java b/.../springmvc-client/src/main/java/io/servicecomb/demo/springmvc/client/SpringmvcClient.java
@@ -95,9 +95,10 @@ public static void run() throws Exception {
       String content = restTemplate.getForObject("cse://springmvc/codeFirstSpringmvc/metricsForTest", String.class);
       Map<String, String> resultMap = JsonUtils.OBJ_MAPPER.readValue(content, HashMap.class);
 
-      TestMgr.check(String.valueOf(true), String.valueOf(resultMap.get("CPU and Memory").contains("heapUsed=")));
+      TestMgr.check(true, resultMap.get("CPU and Memory").contains("heapUsed="));
 
-      String[] requestProviders = resultMap.get("totalRequestProvider OPERATIONAL_LEVEL").replace("{", "")
+      String[] requestProviders = resultMap.get("totalRequestProvider OPERATIONAL_LEVEL")
+          .replace("{", "")
           .replace("}", "").split(",");
       Map<String, Integer> requests = new HashMap<>();
       for (String requestProvider : requestProviders) {
@@ -106,13 +107,11 @@ public static void run() throws Exception {
       }
 
       for (Entry<String, Integer> request : requests.entrySet()) {
-        TestMgr.check(String.valueOf(true), String.valueOf(request.getValue() > 0));
+        TestMgr.check(true, request.getValue() > 0);
       }
 
-      TestMgr.check(String.valueOf(true),
-          String.valueOf(resultMap.get("RequestQueueRelated").contains("springmvc.codeFirst.saySomething")));
-      TestMgr.check(String.valueOf(true),
-          String.valueOf(resultMap.get("RequestQueueRelated").contains("springmvc.controller.sayHi")));
+      TestMgr.check(true, resultMap.get("RequestQueueRelated").contains("springmvc.codeFirst.saySomething"));
+      TestMgr.check(true, resultMap.get("RequestQueueRelated").contains("springmvc.controller.sayHi"));
     } catch (Exception e) {
       TestMgr.check("true", "false");
     }
@@ -122,10 +121,10 @@ public static void run() throws Exception {
       RegistryMetric metric = metricsPublisher.metrics();
 
       TestMgr
-          .check(String.valueOf(true), String.valueOf(metric.getInstanceMetric().getSystemMetric().getHeapUsed() != 0));
-      TestMgr.check(String.valueOf(true), String.valueOf(metric.getProducerMetrics().size() > 0));
-      TestMgr.check(String.valueOf(true), String.valueOf(
-          metric.getProducerMetrics().get("springmvc.codeFirst.saySomething").getProducerCall().getTotal() > 0));
+          .check(true, metric.getInstanceMetric().getSystemMetric().getHeapUsed() != 0);
+      TestMgr.check(true, metric.getProducerMetrics().size() > 0);
+      TestMgr.check(true,
+          metric.getProducerMetrics().get("springmvc.codeFirst.saySomething").getProducerCall().getTotal() > 0);
     } catch (Exception e) {
       TestMgr.check("true", "false");
     }