[SCB-1071] Protobuf codec support array and primitive and packed #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… value and support write packed value
…pe and support packed value
…e and support packed value
liubao68
reviewed
Jan 14, 2019
| //Copyright 2007-2010 David Yu dyuproject@gmail.com | ||
| //------------------------------------------------------------------------ | ||
| //Licensed under the Apache License, Version 2.0 (the "License"); | ||
| //you may not use this file except in compliance with the License. |
There was a problem hiding this comment.
This file is missed in LICENSE
There was a problem hiding this comment.
ok, changed from ByteBufferInputEx to ByteArrayInputEx, i will fix it.
liubao68
approved these changes
Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a very big PR
because refactor all codec mechanism, and very difficult to split into small PR
please review followed by commit log, not review all of them in one time.
about 10000 lines code in "prepare test data model" is test data model that generated by protobuf, no need to review.