[SCB-1392]Mutiple classes have the same APIModel,and class will occur… #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wujimin
reviewed
Jul 29, 2019
...rator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/utils/ParamUtils.java
Outdated
Show resolved
Hide resolved
wujimin
reviewed
Jul 29, 2019
...nerator-core/src/test/java/org/apache/servicecomb/swagger/generator/core/TestParamUtils.java
Show resolved
Hide resolved
wujimin
reviewed
Jul 30, 2019
...tor/generator-core/src/main/java/org/apache/servicecomb/swagger/extend/ModelResolverExt.java
Outdated
Show resolved
Hide resolved
yhs0092
reviewed
Jul 30, 2019
...nerator-core/src/test/java/org/apache/servicecomb/swagger/generator/core/TestParamUtils.java
Outdated
Show resolved
Hide resolved
GuoYL123
commented
Jul 31, 2019
| Field[] fields2 = AllTypeTest2.class.getDeclaredFields(); | ||
| for (int i = 0; i < fields1.length; i++) { | ||
| for (int j = 0; j < fields2.length; j++) { | ||
| if(fields1[i].isSynthetic()||fields2[j].isSynthetic()){ |
There was a problem hiding this comment.
jacoco will use ASM injecting bytecode into field,this caused a new field named JacocoData will not throw exception when execute addDefinitions.
liubao68
reviewed
Aug 6, 2019
...rator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/utils/ParamUtils.java
Outdated
Show resolved
Hide resolved
liubao68
reviewed
Aug 6, 2019
...nerator-core/src/test/java/org/apache/servicecomb/swagger/generator/core/TestParamUtils.java
Outdated
Show resolved
Hide resolved
… when generating schemaid.
GuoYL123
force-pushed
the
master
branch
2 times, most recently
from
ceb83f1
to
e9d5920
Compare
liubao68
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… when generating schemaid.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean install -Pitto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.