[SCB-1550] add a java client for ServiceComb-Kie #1366
Conversation
client/kie-client/pom.xml
Outdated
| <parent> | ||
| <groupId>org.apache.servicecomb</groupId> | ||
| <artifactId>java-chassis-parent</artifactId> | ||
| <version>1.3.0-SNAPSHOT</version> |
There was a problem hiding this comment.
Lastest has changed to 2.0.0-SNAPSHOT
There was a problem hiding this comment.
<parent>
<groupId>org.apache.servicecomb</groupId>
<artifactId>java-chassis-parent</artifactId>
<version>2.0.0-SNAPSHOT</version>
<relativePath>../parents/default</relativePath>
</parent>
relativePath is required for compiling.
client/kie-client/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.apache.httpcomponents</groupId> | ||
| <artifactId>httpclient</artifactId> | ||
| <version>4.5.7</version> |
There was a problem hiding this comment.
3td parties should managed by dependency management. see java-chassis-dependencies and take a look at other modules.
| LOGGER.info("putKeyValue result:" + response.getContent()); | ||
| return response.getContent(); | ||
| } else { | ||
| throw new OperationsException(response.getStatusCode() + response.getMessage() + response.getContent()); |
There was a problem hiding this comment.
Because you have catched the exception, this statement equals log the error.
| throw new OperationsException(response.getStatusCode() + response.getMessage() + response.getContent()); | ||
| } | ||
| } catch (IOException | OperationsException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
use Logger to log the message
| try { | ||
| HttpResponse response = httpClient.getHttpRequest("/kie/kv/" + key, null, null); | ||
| if (response.getStatusCode() == HttpStatus.SC_OK) { | ||
| LOGGER.info("getKeyValue result:" + response.getContent()); |
There was a problem hiding this comment.
Do not log the result of successful operation. Will cause a lot of unneccessary logs.
| * @param key | ||
| * @return | ||
| */ | ||
| public List<KVResponse> getValueOfKey(String key) { |
There was a problem hiding this comment.
Since this operation will not throw exception, should document this API that when return null, it is some error happens. And maybe define some XXXException for this module is better for users to use this API.
|
|
||
| private String key; | ||
|
|
||
| private String label_id; |
There was a problem hiding this comment.
Are these name required？ Can make them to follow java conventions?
| } | ||
|
|
||
| public HttpTransportImpl() { | ||
| httpClient = HttpClients.createDefault(); |
There was a problem hiding this comment.
Need to create a task to implement TLS. A lot of security settings should be set.
| @@ -125,6 +125,7 @@ | |||
| <module>java-chassis-spring-boot</module> | |||
| <module>inspector</module> | |||
| <module>solutions</module> | |||
| <module>client/kie-client</module> | |||
There was a problem hiding this comment.
Create a subtask to implement dynamic config module for kie.
|
https://docs.servicecomb.io/java-chassis/zh_CN/build-consumer/3rd-party-service-invoke.html |
|
@liubao68 Thank you for your comments. I optimized the code based on your suggestion. |
|
Maybe your IDE formatter is wrong. Please use formatters in etc folder of this project to format code. |
|
@liubao68 thanks for reminding, the code format is now standardized. |
| } | ||
|
|
||
| public Builder setDomainName(String domainName) { | ||
| if (domainName == null) { |
There was a problem hiding this comment.
I think delete this code is better. Port, Host is the same. [minor]
There was a problem hiding this comment.
The domainName means projectName, mayebe this naming is easy to misunderstand. I can change the name to projectName.
The base api path is "/v1/{project}/kie/kv/" in swagger. The default value of {project} is default, which can also be customized by the user.
Add a sample Java client of ServiceComb-Kie to ServiceComb project ( ServiceComb-Java-chassis ).
Reference go-client ( https://github.com/apache/servicecomb-kie/blob/master/client/client.go)
Implement the Java client of ServiceComb-Kie.