【SCB-1615】Extended dynamic configuration support for Nacos #1405

160731liupf · 2019-11-22T05:23:39Z

How to use:
1.Download base model from http://start.servicecomb.io and add maven dependence:

org.apache.servicecomb
config-nacos
2.0.0-SNAPSHOT

2.Start nacos console model(git url:https://github.com/alibaba/nacos) ,both account and password is "nacos" and add properties(example):
Data ID: example
Group:DEFAULT_GROUP
JSON:
{
"nacos":"666"
}
3.In base model,add info in microservice.yaml:
nacos:
config:
serverAddr: 127.0.0.1:8848
dataId: example
group: DEFAULT_GROUP
4.Then add blow code and start base model,you will get properties(If properties on nacos has changed, you can also get new value):
@RestSchema(schemaId = "nacos")
@RequestMapping(path = "/")
public class NacosImpl {
/**

从nacos获取配置
@return
*/
@GetMapping(path = "/config")
@responsebody
public String config() throws Exception{
final String config = DynamicPropertyFactory.getInstance()
.getStringProperty("nacos","").getValue();
return JSON.toJSONString(config);
}
}

merge code

update code

merge code

…ava-chassis

coveralls · 2019-11-22T05:56:16Z

Coverage decreased (-0.08%) to 85.365% when pulling e0925a5 on 160731liupf:master into 7701260 on apache:master.

liubao68 · 2019-11-22T07:24:21Z

dynamic-config/config-apollo/pom.xml

+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-jdk14</artifactId>
+    </dependency>


Why you modifiy this? I think can be deleted.

Sorry,It's my fault.Mybe my project is not full compilation .A few days ago,When I run test in config-apollo,I found it print nothing.There is no need to add this dependency,I had remove it in a new commit.

liubao68 · 2019-11-22T07:24:37Z

dynamic-config/config-cc/pom.xml

+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-jdk14</artifactId>
+    </dependency>


same as above

It has removed in a new commit.

liubao68 · 2019-11-22T07:31:38Z

dynamic-config/config-nacos/pom.xml

+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-jdk14</artifactId>
+    </dependency>


Does nacos must use jdk logger? ServiceComb use sl4j to log messages, and users can choose from jdk logger, log4j, logback, log4j2, etc. It's better not put this dependency

I had removed it in a new commit

liubao68 · 2019-11-22T08:25:41Z

suggestions: you can add a README.md file for this module, and put your usage guide in this file.

160731liupf · 2019-11-22T16:17:23Z

suggestions: you can add a README.md file for this module, and put your usage guide in this file.

Thanks for your suggestions,I had create a new commit to remove dependency and add README.md file.

liubao68 · 2019-11-25T04:00:20Z

java-chassis-dependencies/default/pom.xml

@@ -1341,6 +1343,11 @@
        <artifactId>business-service-springmvc-archetype</artifactId>
        <version>${project.version}</version>
      </dependency>
+      <dependency>


Add new libraries need update LICENCE file in ${HOME}/java-chassis-distributioni/release/src/LICENCE

I had add
"* nacos-client (com.alibaba.nacos:1.1.4 - https://github.com/alibaba/nacos)"
in LICENSE file.

liubao68 · 2019-11-25T04:01:36Z

dynamic-config/config-nacos/src/main/java/org/apache/servicecomb/config/client/NacosClient.java

+      }catch (Exception e){
+          LOGGER.error("Receive nacos config error: ", e);
+      }


A small piece of code is not well formatted using code template in ${HOME}/etc

可以用中文解释一下吗？我不明白要怎么修改比较好

有少量代码没有正确格式化（比如空格等），可以使用IDE自动格式化一下。格式化模板在servicecomb的 etc 目录。里面包含了eclipse, IDEA等IDE的格式化模板。

你好，config-nacos 模块我已经用intellij-java-google-style.xml格式化好了，这是pr地址：https://github.com/apache/servicecomb-java-chassis/pull/1414/files

liubao68 · 2019-11-25T04:07:41Z

...fig/config-nacos/src/main/java/org/apache/servicecomb/config/client/ConfigurationAction.java

+
+package org.apache.servicecomb.config.client;
+
+public enum ConfigurationAction {


You used same package and class name with config-appolo. I Suggest you refactor all code to use a different package name for all class. e.g.

org.apache.servicecomb.config.nacos

And we will handle other implentations, maybe in future.

The package name of config-nacos model has replaced with "org.apache.servicecomb.config.nacos".

liubao68 · 2019-11-25T04:08:43Z

...c/main/java/org/apache/servicecomb/config/archaius/sources/NacosConfigurationSourceImpl.java

+
+  private List<WatchedUpdateListener> listeners = new CopyOnWriteArrayList<>();
+
+  private static final String NACOS_CONFIG_SERVER_ADDR_KEY = "nacos.config.serverAddr";


Can use the same constant in NacosConfig

The name of key is replaced with "SERVER_ADDR".

merge code

…ava-chassis

160731liupf added 11 commits November 15, 2019 19:45

Merge pull request #3 from apache/master

b60ba97

merge code

Merge pull request #4 from apache/master

19287c8

update code

Merge pull request #5 from apache/master

cc86c12

merge code

add nacos model

66e37ed

add nacos model

cea236f

nacos client

6447f38

optimize nacos model

7ca23b7

Merge branch 'practice'

5a54d2f

Merge branch 'master' of https://github.com/160731liupf/servicecomb-j…

e8789d9

…ava-chassis

optimize nacos test

2072685

add NacosConfigurationSourceImpl properties

f32bde9

160731liupf mentioned this pull request Nov 22, 2019

对接 Nacos 配置中心 #1354

Closed

liubao68 reviewed Nov 22, 2019

View reviewed changes

remove slf4j-jdk14 and add README.md file

d1d137a

liubao68 reviewed Nov 25, 2019

View reviewed changes

160731liupf added 3 commits November 26, 2019 06:48

update license and use different package

711b653

Merge pull request #6 from apache/master

50b88ee

merge code

Merge branch 'master' of https://github.com/160731liupf/servicecomb-j…

e0925a5

…ava-chassis

liubao68 approved these changes Nov 26, 2019

View reviewed changes

liubao68 merged commit 20ff2f0 into apache:master Nov 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

【SCB-1615】Extended dynamic configuration support for Nacos #1405

【SCB-1615】Extended dynamic configuration support for Nacos #1405

160731liupf commented Nov 22, 2019

coveralls commented Nov 22, 2019 •

edited

liubao68 Nov 22, 2019

160731liupf Nov 22, 2019

liubao68 Nov 22, 2019

160731liupf Nov 22, 2019

liubao68 Nov 22, 2019

160731liupf Nov 22, 2019

liubao68 commented Nov 22, 2019

160731liupf commented Nov 22, 2019

liubao68 Nov 25, 2019

160731liupf Nov 25, 2019

liubao68 Nov 25, 2019

160731liupf Nov 25, 2019

liubao68 Nov 26, 2019

160731liupf Nov 27, 2019

liubao68 Nov 25, 2019

160731liupf Nov 25, 2019

liubao68 Nov 25, 2019

160731liupf Nov 25, 2019


		package org.apache.servicecomb.config.client;

		public enum ConfigurationAction {


		private List<WatchedUpdateListener> listeners = new CopyOnWriteArrayList<>();

		private static final String NACOS_CONFIG_SERVER_ADDR_KEY = "nacos.config.serverAddr";

【SCB-1615】Extended dynamic configuration support for Nacos #1405

【SCB-1615】Extended dynamic configuration support for Nacos #1405

Conversation

160731liupf commented Nov 22, 2019

coveralls commented Nov 22, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liubao68 commented Nov 22, 2019

160731liupf commented Nov 22, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Nov 22, 2019 •

edited