Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-1795] when use query object, sdk don't support fluent setter #1623

Merged
merged 3 commits into from Mar 19, 2020

Conversation

heyile
Copy link
Contributor

@heyile heyile commented Mar 5, 2020

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

coveralls commented Mar 6, 2020

Coverage Status

Coverage increased (+0.1%) to 84.897% when pulling f5c1641 on heyile:scb-1795 into 192e4ac on apache:master.

@heyile
Copy link
Contributor Author

heyile commented Mar 18, 2020

modify as bellow:

  • edge invocation in it-test will be invoked twice in a row

  • testNullFieldAndDefaultValue has been moved to class TestSpringMVCObjectParamTypeRestOnly

@liubao68 liubao68 merged commit d0655d7 into apache:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants