Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SCB-1936] change findbug dependency to provided #1778

Merged
merged 1 commit into from May 27, 2020
Merged

[SCB-1936] change findbug dependency to provided #1778

merged 1 commit into from May 27, 2020

Conversation

wujimin
Copy link
Contributor

@wujimin wujimin commented May 26, 2020

No description provided.

@wujimin wujimin requested review from yhs0092 and liubao68 May 26, 2020 12:31
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 84.61% when pulling 43c0fe3 on wujimin:SCB-1936-change-findbug-dependency-to-provided into 71fd15c on apache:master.

@liubao68
Copy link
Contributor

liubao68 commented May 26, 2020 •
edited

Does jsr 305 required for running java-chassis in vert.x mode?

  • if it is: does users have another choise without google implementation
  • if it is not: why we can not remove it totally from the project

@wujimin
Copy link
Contributor Author

wujimin commented May 26, 2020 •
edited

no need for runtime, add them just for resolve compile warning

@liubao68 liubao68 merged commit 64a7179 into apache:master May 27, 2020
@wujimin wujimin deleted the SCB-1936-change-findbug-dependency-to-provided branch May 28, 2020 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhs0092 yhs0092 Awaiting requested review from yhs0092

@liubao68 liubao68 Awaiting requested review from liubao68

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wujimin @coveralls @liubao68