[SCB-1995]Fix incorrect message issue identifed through testing #1825
Conversation
| byte[] buffer = new byte[DATA_PACKET_BUFFER_SIZE]; | ||
| DatagramPacket receivePacketBuffer = new DatagramPacket(buffer, buffer.length); | ||
| multicastSocket.receive(receivePacketBuffer); | ||
| String receivedPacketString = new String(receivePacketBuffer.getData(), ENCODE); |
There was a problem hiding this comment.
This logic seams not correct. Maybe you'd check the length of data actually received and using the correct data.
There was a problem hiding this comment.
good point. Unfortunately, based on the Multicast working mechanism, we have to create a buffer before data is received. After data is received, then buffer is filled with the received data. So we can't create a buffer with size exactly same as the received data.
By the way, it's also mentioned in the JDK source code comments:
https://github.com/frohoff/jdk8u-jdk/blob/master/src/share/classes/java/net/DatagramSocket.java#L698-L700
There was a problem hiding this comment.
Maybe you misunderstanding my point. You should do this
multicastSocket.receive(receivePacketBuffer);
int len = receivePacketBuffer.getLength() ;
if(len > 0) {
String receivedPacketString = new String(receivePacketBuffer.getData(), 0, len, ENCODE);
}
And you can avoid creating new buffers for each receive, though this is not very important because the next receive happens in seconds.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean install -Pitto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.