[SCB-1832] Edge will lose public request headers:old request maybe null #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liubao68
reviewed
Jul 14, 2020
| @@ -75,6 +75,9 @@ public boolean enabled() { | |||
|
|
|||
| @Override | |||
| public void beforeSendRequest(Invocation invocation, HttpServletRequestEx requestEx) { | |||
| if (!invocation.isEdge()) { | |||
There was a problem hiding this comment.
Can you add a test case for this secenio? There is a demo in demo-edge , and can easily test this scenario. demo-edge will also be run when PR is submited. You can look at docker-run-config-edge for infromation on how to run demo-edge in local IDE and run in docker.
liubao68
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean install -Pitto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.