[SCB-2041]nacos module support json/yaml/properties format #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liubao68
reviewed
Jul 14, 2020
| @@ -41,96 +41,96 @@ | |||
| import com.netflix.config.WatchedUpdateResult; | |||
|
|
|||
| public class NacosConfigurationSourceImpl implements ConfigCenterConfigurationSource { | |||
| private static final Logger LOGGER = LoggerFactory.getLogger(ConfigCenterConfigurationSource.class); | |||
| private static final Logger LOGGER = LoggerFactory.getLogger(ConfigCenterConfigurationSource.class); | |||
There was a problem hiding this comment.
This project using google code style, maybe you need to add it to your editor. For IDEA and eclipse, this file is in $java-chassis/etc folder.
There was a problem hiding this comment.
Seems travis CI got some problem. You can first fix code style problem and submit a commit direct to this PR, the CI will be retriggerd . Because you used the wrong formatter, this makes it a bit more difficult review code in github.
liubao68
changed the title
|
Fixed in #1911 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.mvn clean install -Pitto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.