Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2070]when main is default package(empty), start up will fail #2112

Merged
merged 1 commit into from Dec 9, 2020
Merged

[SCB-2070]when main is default package(empty), start up will fail #2112

merged 1 commit into from Dec 9, 2020

Conversation

liubao68
Copy link
Contributor

@liubao68 liubao68 commented Dec 9, 2020

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@liubao68 liubao68 requested a review from wujimin December 9, 2020 07:53
@codecov-io
Copy link

Codecov Report

Merging #2112 (f4a1065) into master (9cc06e4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2112      +/-   ##
============================================
+ Coverage     80.85%   80.86%   +0.01%     
  Complexity     1335     1335              
============================================
  Files          1456     1456              
  Lines         39925    39925              
  Branches       3387     3387              
============================================
+ Hits          32281    32286       +5     
+ Misses         6176     6170       -6     
- Partials       1468     1469       +1     
Impacted Files Coverage Δ Complexity Δ
...servicecomb/foundation/common/utils/BeanUtils.java 91.83% <100.00%> (ø) 0.00 <0.00> (ø)
.../servicecomb/config/client/ConfigCenterClient.java 52.11% <0.00%> (-0.43%) 0.00% <0.00%> (ø%)
...egistry/client/http/ServiceRegistryClientImpl.java 70.09% <0.00%> (+0.77%) 0.00% <0.00%> (ø%)
...mb/serviceregistry/client/http/RestClientUtil.java 77.57% <0.00%> (+1.86%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cc06e4...f4a1065. Read the comment docs.

@wujimin wujimin merged commit 751f75d into apache:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants