Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2154] fix Response.isSuccessed typo #2115

Merged

Conversation

wujimin
Copy link
Contributor

@wujimin wujimin commented Dec 9, 2020

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-io
Copy link

Codecov Report

Merging #2115 (8ac7f0c) into master (751f75d) will decrease coverage by 0.01%.
The diff coverage is 44.44%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2115      +/-   ##
============================================
- Coverage     80.88%   80.86%   -0.02%     
  Complexity     1335     1335              
============================================
  Files          1456     1456              
  Lines         39925    39926       +1     
  Branches       3387     3387              
============================================
- Hits          32293    32288       -5     
- Misses         6164     6170       +6     
  Partials       1468     1468              
Impacted Files Coverage Δ Complexity Δ
...rvicecomb/core/provider/consumer/InvokerUtils.java 70.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ecomb/transport/rest/client/RestClientDecoder.java 4.54% <0.00%> (ø) 0.00 <0.00> (ø)
.../org/apache/servicecomb/provider/pojo/Invoker.java 80.64% <50.00%> (ø) 0.00 <0.00> (ø)
...mvc/reference/async/CseAsyncClientHttpRequest.java 91.66% <50.00%> (ø) 0.00 <0.00> (ø)
...pache/servicecomb/swagger/invocation/Response.java 88.57% <50.00%> (-1.29%) 0.00 <0.00> (ø)
...ider/springmvc/reference/CseClientHttpRequest.java 87.80% <100.00%> (ø) 0.00 <0.00> (ø)
...pache/servicecomb/config/kie/client/KieClient.java 72.61% <0.00%> (-5.96%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 751f75d...8ac7f0c. Read the comment docs.

@wujimin wujimin merged commit afd1d37 into apache:master Dec 9, 2020
@wujimin wujimin deleted the SCB-2154-fix-Response.isSuccessed-typo branch December 16, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants