Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2171] avoid leak server ip when process TimeoutException #2162

Conversation

wujimin
Copy link
Contributor

@wujimin wujimin commented Dec 24, 2020

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-io
Copy link

Codecov Report

Merging #2162 (6b6be2d) into master (4546c6d) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2162      +/-   ##
============================================
- Coverage     80.69%   80.67%   -0.03%     
  Complexity     1339     1339              
============================================
  Files          1462     1462              
  Lines         40185    40186       +1     
  Branches       3412     3412              
============================================
- Hits          32429    32419      -10     
- Misses         6290     6299       +9     
- Partials       1466     1468       +2     
Impacted Files Coverage Δ Complexity Δ
...exception/converter/TimeoutExceptionConverter.java 57.14% <33.33%> (+7.14%) 0.00 <0.00> (ø)
...b/foundation/vertx/server/TcpServerConnection.java 58.82% <0.00%> (-17.65%) 0.00% <0.00%> (ø%)
...pache/servicecomb/config/kie/client/KieClient.java 72.61% <0.00%> (-5.96%) 0.00% <0.00%> (ø%)
.../servicecomb/registry/discovery/DiscoveryTree.java 96.49% <0.00%> (-3.51%) 0.00% <0.00%> (ø%)
...ecomb/provider/pojo/PojoConsumerMetaRefresher.java 75.60% <0.00%> (-2.44%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4546c6d...6b6be2d. Read the comment docs.

@liubao68 liubao68 merged commit 43975bd into apache:master Dec 24, 2020
@wujimin wujimin deleted the SCB-2171-avoid-leak-server-ip-when-process-TimeoutException branch March 12, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants