Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2116]improve algorithm to match when applying rules #2180

Merged
merged 7 commits into from Jan 11, 2021
Merged

[SCB-2116]improve algorithm to match when applying rules #2180

merged 7 commits into from Jan 11, 2021

Conversation

liubao68
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-io
Copy link

codecov-io commented Dec 30, 2020

Codecov Report

Merging #2180 (97346bd) into master (4fc0796) will increase coverage by 0.09%.
The diff coverage is 63.43%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2180      +/-   ##
============================================
+ Coverage     80.38%   80.47%   +0.09%     
- Complexity     1339     1351      +12     
============================================
  Files          1483     1487       +4     
  Lines         40296    40485     +189     
  Branches       3433     3471      +38     
============================================
+ Hits          32390    32579     +189     
+ Misses         6451     6413      -38     
- Partials       1455     1493      +38     
Impacted Files Coverage Δ Complexity Δ
...servicecomb/foundation/common/utils/BeanUtils.java 86.53% <0.00%> (-5.30%) 0.00 <0.00> (ø)
...comb/governance/properties/BulkheadProperties.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...overnance/properties/CircuitBreakerProperties.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...omb/governance/properties/RateLimitProperties.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...icecomb/governance/properties/RetryProperties.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...vicecomb/governance/service/PolicyServiceImpl.java 3.84% <0.00%> (ø) 0.00 <0.00> (ø)
...che/servicecomb/governance/policy/RetryPolicy.java 33.33% <20.00%> (+9.33%) 0.00 <0.00> (ø)
...cecomb/governance/policy/CircuitBreakerPolicy.java 34.61% <23.07%> (-3.85%) 0.00 <0.00> (ø)
.../servicecomb/governance/policy/AbstractPolicy.java 47.61% <28.57%> (+11.25%) 0.00 <0.00> (ø)
...e/servicecomb/governance/marker/TrafficMarker.java 35.71% <31.81%> (-21.43%) 0.00 <0.00> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fc0796...97346bd. Read the comment docs.

@liubao68 liubao68 changed the title [SCB-2116]improve algorithm to match when applying rules [WIP][SCB-2116]improve algorithm to match when applying rules Jan 7, 2021
@liubao68 liubao68 changed the title [WIP][SCB-2116]improve algorithm to match when applying rules [SCB-2116]improve algorithm to match when applying rules Jan 11, 2021
@liubao68 liubao68 merged commit 24090b0 into apache:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants