Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2218] allow edge invocation process by filter #2297

Conversation

wujimin
Copy link
Contributor

@wujimin wujimin commented Mar 17, 2021

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@wujimin wujimin force-pushed the SCB-2218-allow-edge-invocation-process-by-filter branch from c1802a7 to 9f65d8d Compare March 18, 2021 02:12
@wujimin wujimin force-pushed the SCB-2218-allow-edge-invocation-process-by-filter branch from 9f65d8d to eda5b75 Compare March 18, 2021 02:48
@codecov-io
Copy link

Codecov Report

Merging #2297 (eda5b75) into master (6e0143f) will decrease coverage by 0.09%.
The diff coverage is 28.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2297      +/-   ##
============================================
- Coverage     79.45%   79.35%   -0.10%     
  Complexity     1369     1369              
============================================
  Files          1526     1529       +3     
  Lines         40935    40994      +59     
  Branches       3460     3460              
============================================
+ Hits          32524    32530       +6     
- Misses         6920     6972      +52     
- Partials       1491     1492       +1     
Impacted Files Coverage Δ Complexity Δ
...ommon/rest/RestVertxProducerInvocationCreator.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...n/java/org/apache/servicecomb/core/Invocation.java 85.97% <0.00%> (+0.08%) 0.00 <0.00> (ø)
...rvicecomb/edge/core/EdgeAddHeaderClientFilter.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...che/servicecomb/edge/core/EdgeAddHeaderFilter.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...e/servicecomb/edge/core/EdgeInvocationCreator.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...servicecomb/edge/core/EdgeRestTransportClient.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...e/servicecomb/edge/core/EdgeServerCodecFilter.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../apache/servicecomb/registry/lightweight/Self.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...omb/transport/highway/HighwayServerConnection.java 44.11% <0.00%> (ø) 0.00 <0.00> (ø)
...comb/transport/rest/vertx/VertxHttpDispatcher.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0143f...eda5b75. Read the comment docs.

@liubao68 liubao68 merged commit 92a8490 into apache:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants