Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2234] configuration for instance properties should support placeholder #2310

Merged

Conversation

wujimin
Copy link
Contributor

@wujimin wujimin commented Mar 23, 2021

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@wujimin wujimin requested a review from liubao68 March 23, 2021 02:48
@wujimin wujimin force-pushed the SCB-2234-instance-properties-placeholder branch from 9f1a293 to 3a4aa83 Compare March 23, 2021 03:52
@codecov-io
Copy link

Codecov Report

Merging #2310 (3a4aa83) into master (8619d5c) will decrease coverage by 0.02%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2310      +/-   ##
============================================
- Coverage     79.27%   79.24%   -0.03%     
  Complexity     1369     1369              
============================================
  Files          1535     1535              
  Lines         41087    41092       +5     
  Branches       3466     3466              
============================================
- Hits          32572    32564       -8     
- Misses         7014     7025      +11     
- Partials       1501     1503       +2     
Impacted Files Coverage Δ Complexity Δ
...java/org/apache/servicecomb/zeroconfig/Config.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...java/org/apache/servicecomb/config/ConfigUtil.java 88.02% <50.00%> (-0.63%) 0.00 <0.00> (ø)
...apache/servicecomb/config/BootStrapProperties.java 66.12% <75.00%> (-2.73%) 0.00 <0.00> (ø)
...in/java/org/apache/servicecomb/core/SCBEngine.java 77.51% <100.00%> (+0.27%) 0.00 <0.00> (ø)
...ache/servicecomb/registry/RegistrationManager.java 88.27% <100.00%> (ø) 0.00 <0.00> (ø)
.../servicecomb/registry/discovery/DiscoveryTree.java 96.49% <0.00%> (-3.51%) 0.00% <0.00%> (ø%)
...mb/serviceregistry/client/http/RestClientUtil.java 75.70% <0.00%> (-1.87%) 0.00% <0.00%> (ø%)
...egistry/client/http/ServiceRegistryClientImpl.java 69.32% <0.00%> (-1.17%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8619d5c...3a4aa83. Read the comment docs.

@liubao68 liubao68 merged commit 1156705 into apache:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants