Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2257][SCB-2258]governance support http based match #2361

Merged
merged 3 commits into from Apr 27, 2021
Merged

[SCB-2257][SCB-2258]governance support http based match #2361

merged 3 commits into from Apr 27, 2021

Conversation

liubao68
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2021

Codecov Report

Merging #2361 (8b35783) into master (4bb3002) will decrease coverage by 0.01%.
The diff coverage is 94.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2361      +/-   ##
============================================
- Coverage     80.29%   80.28%   -0.02%     
- Complexity     1375     1379       +4     
============================================
  Files          1554     1554              
  Lines         41449    41462      +13     
  Branches       3480     3480              
============================================
+ Hits          33282    33288       +6     
- Misses         6662     6669       +7     
  Partials       1505     1505              
Impacted Files Coverage Δ Complexity Δ
...e/servicecomb/core/definition/OperationConfig.java 87.03% <66.66%> (-1.20%) 0.00 <0.00> (ø)
...vicecomb/demo/zeroconfig/tests/GovernanceTest.java 87.62% <100.00%> (+1.42%) 16.00 <4.00> (+4.00)
...mb/serviceregistry/client/http/RestClientUtil.java 75.70% <0.00%> (-1.87%) 0.00% <0.00%> (ø%)
...egistry/client/http/ServiceRegistryClientImpl.java 68.73% <0.00%> (-1.17%) 0.00% <0.00%> (ø%)
...b/loadbalance/filter/IsolationDiscoveryFilter.java 97.43% <0.00%> (+2.56%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bb3002...8b35783. Read the comment docs.

@liubao68 liubao68 changed the title fix port conflict with build environment [SCB-2257][SCB-2258]governance support http based match Apr 27, 2021
@liubao68 liubao68 merged commit 09e5381 into apache:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants