Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2261]change block wait to checked wait to avoid request timeout … #2367

Merged
merged 1 commit into from May 8, 2021
Merged

Conversation

liubao68
Copy link
Contributor

@liubao68 liubao68 commented May 7, 2021

…exceed invocation timeout

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@liubao68 liubao68 requested review from wujimin and yhs0092 May 7, 2021 08:31
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2021

Codecov Report

Merging #2367 (8924210) into master (8a3942a) will increase coverage by 0.02%.
The diff coverage is 65.38%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2367      +/-   ##
============================================
+ Coverage     80.29%   80.31%   +0.02%     
  Complexity     1380     1380              
============================================
  Files          1559     1559              
  Lines         41502    41521      +19     
  Branches       3483     3487       +4     
============================================
+ Hits          33322    33346      +24     
+ Misses         6672     6667       -5     
  Partials       1508     1508              
Impacted Files Coverage Δ Complexity Δ
...b/core/provider/consumer/SyncResponseExecutor.java 79.31% <62.50%> (-20.69%) 0.00 <0.00> (ø)
...mvc/client/TestSpringMVCCommonSchemaInterface.java 68.42% <62.50%> (-1.58%) 6.00 <1.00> (+1.00) ⬇️
...rvicecomb/core/provider/consumer/InvokerUtils.java 69.87% <100.00%> (+9.87%) 0.00 <0.00> (ø)
...rvicecomb/demo/jaxrs/client/TestClientTimeout.java 72.22% <100.00%> (-22.90%) 6.00 <0.00> (-1.00)
...thentication/consumer/RSAConsumerTokenManager.java 77.41% <0.00%> (-1.16%) 0.00% <0.00%> (ø%)
...b/authentication/consumer/ConsumerAuthHandler.java 100.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...egistry/client/http/ServiceRegistryClientImpl.java 69.90% <0.00%> (+1.16%) 0.00% <0.00%> (ø%)
...mb/serviceregistry/client/http/RestClientUtil.java 77.57% <0.00%> (+1.86%) 0.00% <0.00%> (ø%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a3942a...8924210. Read the comment docs.

@wujimin wujimin merged commit 3115a23 into apache:master May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants