Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2274]change connecting config/dashboard services rule to round robbin #2404

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Conversation

liubao68
Copy link
Contributor

@liubao68 liubao68 commented Jun 7, 2021

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #2404 (7d6453a) into master (d666309) will increase coverage by 0.04%.
The diff coverage is 42.30%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2404      +/-   ##
============================================
+ Coverage     79.93%   79.97%   +0.04%     
  Complexity     1408     1408              
============================================
  Files          1549     1549              
  Lines         41356    41348       -8     
  Branches       3444     3444              
============================================
+ Hits          33057    33068      +11     
+ Misses         6826     6808      -18     
+ Partials       1473     1472       -1     
Impacted Files Coverage Δ
...pache/servicecomb/config/kie/client/KieClient.java 0.00% <0.00%> (ø)
...omb/config/kie/client/model/KieAddressManager.java 0.00% <0.00%> (ø)
.../service/center/client/ServiceCenterRawClient.java 67.64% <ø> (+3.75%) ⬆️
...comb/service/center/client/ServiceCenterWatch.java 0.00% <0.00%> (ø)
...vicecomb/service/center/client/AddressManager.java 64.70% <80.00%> (+19.70%) ⬆️
...rvicecomb/config/center/client/AddressManager.java 68.75% <100.00%> (-4.94%) ⬇️
...ecomb/config/center/client/ConfigCenterClient.java 46.93% <100.00%> (+3.46%) ⬆️
...egistry/client/http/ServiceRegistryClientImpl.java 70.01% <0.00%> (+1.16%) ⬆️
...mb/serviceregistry/client/http/RestClientUtil.java 77.57% <0.00%> (+1.86%) ⬆️
...ecomb/provider/pojo/PojoConsumerMetaRefresher.java 78.04% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d666309...7d6453a. Read the comment docs.

@liubao68 liubao68 merged commit efbeee2 into apache:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants