Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2288]add a configuration for ssl client auth type #2469

Merged
merged 1 commit into from
Jul 15, 2021
Merged

[SCB-2288]add a configuration for ssl client auth type #2469

merged 1 commit into from
Jul 15, 2021

Conversation

liubao68
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #2469 (adf17da) into master (80dd6d0) will decrease coverage by 0.06%.
The diff coverage is 55.38%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2469      +/-   ##
============================================
- Coverage     79.95%   79.89%   -0.07%     
  Complexity     1415     1415              
============================================
  Files          1549     1550       +1     
  Lines         41401    41445      +44     
  Branches       3453     3456       +3     
============================================
+ Hits          33104    33114      +10     
- Misses         6816     6844      +28     
- Partials       1481     1487       +6     
Impacted Files Coverage Δ
.../org/apache/servicecomb/config/TransportUtils.java 5.08% <0.00%> (-0.28%) ⬇️
.../apache/servicecomb/config/kie/TransportUtils.java 0.00% <0.00%> (ø)
.../apache/servicecomb/foundation/ssl/ClientAuth.java 0.00% <0.00%> (ø)
...omb/serviceregistry/auth/RBACBootStrapService.java 4.87% <0.00%> (-0.19%) ⬇️
.../servicecomb/foundation/vertx/VertxTLSBuilder.java 65.47% <45.45%> (-2.95%) ⬇️
.../apache/servicecomb/foundation/ssl/SSLManager.java 86.77% <67.64%> (-8.37%) ⬇️
...g/apache/servicecomb/foundation/ssl/SSLOption.java 91.07% <80.00%> (+0.34%) ⬆️
...mb/serviceregistry/client/http/RestClientUtil.java 75.70% <0.00%> (-1.87%) ⬇️
...egistry/client/http/ServiceRegistryClientImpl.java 68.85% <0.00%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80dd6d0...adf17da. Read the comment docs.

@liubao68 liubao68 merged commit 1c4efc5 into apache:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants