Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2303]retry count should be actual retries needed, not include the request #2475

Merged
merged 3 commits into from Jul 23, 2021

Conversation

develpoerX
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #2475 (1816bf6) into master (9a900be) will decrease coverage by 0.00%.
The diff coverage is 41.17%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2475      +/-   ##
============================================
- Coverage     79.33%   79.32%   -0.01%     
  Complexity     1416     1416              
============================================
  Files          1554     1554              
  Lines         41466    41474       +8     
  Branches       3463     3465       +2     
============================================
+ Hits          32895    32899       +4     
- Misses         7087     7088       +1     
- Partials       1484     1487       +3     
Impacted Files Coverage Δ
...comb/governance/handler/CircuitBreakerHandler.java 11.11% <0.00%> (ø)
...e/servicecomb/governance/handler/RetryHandler.java 10.52% <0.00%> (ø)
...cecomb/governance/policy/CircuitBreakerPolicy.java 43.54% <46.66%> (+2.80%) ⬆️
...ache/servicecomb/foundation/common/net/IpPort.java 83.33% <0.00%> (-3.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a900be...1816bf6. Read the comment docs.

@liubao68 liubao68 changed the title # modify retry policy [SCB-2303]retry count should be actual retries needed, not include the request Jul 23, 2021
@liubao68 liubao68 merged commit e5448c0 into apache:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants