Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# SCB-2322 remove service center client wrong readme #2524

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

develpoerX
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #2524 (83dd97b) into master (b61a219) will decrease coverage by 1.56%.
The diff coverage is 0.00%.

❗ Current head 83dd97b differs from pull request most recent head a0f756f. Consider uploading reports for the commit a0f756f to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2524      +/-   ##
============================================
- Coverage     79.19%   77.62%   -1.57%     
  Complexity     1419     1419              
============================================
  Files          1559     1597      +38     
  Lines         41574    42403     +829     
  Branches       3470     3568      +98     
============================================
- Hits          32926    32917       -9     
- Misses         7158     7996     +838     
  Partials       1490     1490              
Impacted Files Coverage Δ
...ecomb/config/center/client/ConfigCenterClient.java 44.23% <0.00%> (-2.71%) ⬇️
.../apache/servicecomb/darklaunch/DarklaunchRule.java 0.00% <0.00%> (ø)
...che/servicecomb/darklaunch/DarklaunchRuleItem.java 0.00% <0.00%> (ø)
...servicecomb/darklaunch/DarklaunchRuleItemJson.java 0.00% <0.00%> (ø)
...che/servicecomb/darklaunch/DarklaunchRuleJson.java 0.00% <0.00%> (ø)
...icecomb/darklaunch/DarklaunchServerListFilter.java 0.00% <0.00%> (ø)
...ache/servicecomb/darklaunch/MicroserviceCache.java 0.00% <0.00%> (ø)
.../org/apache/servicecomb/darklaunch/PolicyType.java 0.00% <0.00%> (ø)
...servicecomb/darklaunch/oper/AbstractCondition.java 0.00% <0.00%> (ø)
...ache/servicecomb/darklaunch/oper/AndCondition.java 0.00% <0.00%> (ø)
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 094119f...a0f756f. Read the comment docs.

@liubao68 liubao68 merged commit ba7a72f into apache:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants