[SCB-2351] Optimize the ping method #2626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are multiple endpoints, ping only the first one may cause the available services to be defined as unavailable
Closed
miss logger
Codecov Report
@@ Coverage Diff @@
## master #2626 +/- ##
============================================
+ Coverage 77.72% 77.74% +0.01%
Complexity 1429 1429
============================================
Files 1598 1598
Lines 42652 42657 +5
Branches 3591 3592 +1
============================================
+ Hits 33151 33162 +11
+ Misses 8000 7996 -4
+ Partials 1501 1499 -2
Continue to review full report at Codecov.
|
liubao68
reviewed
Oct 27, 2021
|
|
||
| /** | ||
| * Simple implementation of .MicroserviceInstancePing using telnet | ||
| */ | ||
| public class SimpleMicroserviceInstancePing implements MicroserviceInstancePing { | ||
| private static final Logger LOGGER = LoggerFactory.getLogger(SimpleMicroserviceInstancePing.class); |
There was a problem hiding this comment.
- use etc/*.xml code formatter formate code
- create a JIRA issue and submit a PR with JIRA id, see other PRs
There was a problem hiding this comment.
done, but I'm not sure if I did it right
liubao68
reviewed
Oct 27, 2021
| s.connect(new InetSocketAddress(ipPort.getHostOrIp(), ipPort.getPort()), 3000); | ||
| return true; | ||
| } catch (IOException e) { | ||
| LOGGER.warn("IOException, probable ping instance failed endpoint is {}", endpoint); |
There was a problem hiding this comment.
"ping instance {} endpoint {} failed", instanceid, endpoint
five111
changed the title
use intellij-java-google-style.xml format code and change log
add UT for ping method changed
liubao68
approved these changes
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are multiple endpoints, ping only the first one may cause the available services to be defined as unavailable
#2624