Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2361] Solve URL conversion problem #2715

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Conversation

develpoerX
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@liubao68 liubao68 changed the title # Solve URL conversion problem [SCB-2361] Solve URL conversion problem Feb 11, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2715 (b58fcfb) into master (76916a5) will increase coverage by 0.00%.
The diff coverage is 82.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2715   +/-   ##
=========================================
  Coverage     77.26%   77.27%           
  Complexity     1414     1414           
=========================================
  Files          1613     1614    +1     
  Lines         43184    43207   +23     
  Branches       3660     3664    +4     
=========================================
+ Hits          33366    33388   +22     
+ Misses         8279     8278    -1     
- Partials       1539     1541    +2     
Impacted Files Coverage Δ
...serviceregistry/refresh/ClassificationAddress.java 53.75% <50.00%> (ø)
...he/servicecomb/http/client/common/URLEndPoint.java 92.00% <92.00%> (ø)
...omb/http/client/common/AbstractAddressManager.java 84.00% <100.00%> (-0.26%) ⬇️
...mb/config/ConfigCenterConfigurationSourceImpl.java 10.86% <0.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76916a5...b58fcfb. Read the comment docs.

@liubao68 liubao68 merged commit 2081114 into apache:master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants