Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2673]Fix NPE problem when auto discovery enabled #3299

Merged
merged 4 commits into from
Aug 26, 2022
Merged

[SCB-2673]Fix NPE problem when auto discovery enabled #3299

merged 4 commits into from
Aug 26, 2022

Conversation

liubao68
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #3299 (8a11849) into master (6677331) will increase coverage by 0.00%.
The diff coverage is 67.69%.

❗ Current head 8a11849 differs from pull request most recent head 9e26f48. Consider uploading reports for the commit 9e26f48 to get more accurate results

@@            Coverage Diff            @@
##             master    #3299   +/-   ##
=========================================
  Coverage     77.41%   77.41%           
- Complexity     1449     1452    +3     
=========================================
  Files          1649     1650    +1     
  Lines         43721    43740   +19     
  Branches       3674     3676    +2     
=========================================
+ Hits          33847    33862   +15     
- Misses         8347     8350    +3     
- Partials       1527     1528    +1     
Impacted Files Coverage Δ
...nfig/center/client/ConfigCenterAddressManager.java 100.00% <ø> (ø)
...ecomb/config/center/client/ConfigCenterClient.java 0.00% <0.00%> (ø)
...ice/center/client/ServiceCenterAddressManager.java 71.42% <ø> (ø)
...omb/service/center/client/ServiceCenterClient.java 24.30% <ø> (ø)
...comb/service/center/client/ServiceCenterWatch.java 0.00% <ø> (ø)
...mb/config/ConfigCenterConfigurationSourceImpl.java 10.63% <0.00%> (+1.06%) ⬆️
...omb/serviceregistry/auth/RBACBootStrapService.java 8.53% <0.00%> (ø)
...omb/http/client/common/AbstractAddressManager.java 75.55% <69.56%> (-5.40%) ⬇️
...comb/demo/springmvc/client/TestControllerImpl.java 80.00% <80.00%> (ø)
.../service/center/client/ServiceCenterRawClient.java 65.00% <100.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liubao68 liubao68 merged commit 809e5ce into apache:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants