Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2711]remove unused configuration servicecomb.instance.properties… #3438

Merged
merged 1 commit into from Oct 29, 2022
Merged

Conversation

liubao68
Copy link
Contributor

….tags

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2022

Codecov Report

Merging #3438 (5dbcdf1) into master (1a4485b) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3438      +/-   ##
============================================
+ Coverage     77.54%   77.57%   +0.02%     
  Complexity     1466     1466              
============================================
  Files          1650     1650              
  Lines         43951    43948       -3     
  Branches       3700     3700              
============================================
+ Hits          34082    34092      +10     
+ Misses         8323     8312      -11     
+ Partials       1546     1544       -2     
Impacted Files Coverage Δ
...a/org/apache/servicecomb/config/kie/KieConfig.java 0.00% <ø> (ø)
...apache/servicecomb/config/BootStrapProperties.java 73.77% <ø> (+2.34%) ⬆️
...egistry/client/http/ServiceRegistryClientImpl.java 70.93% <0.00%> (+0.76%) ⬆️
...mb/serviceregistry/client/http/RestClientUtil.java 80.37% <0.00%> (+1.86%) ⬆️
.../servicecomb/registry/discovery/DiscoveryTree.java 100.00% <0.00%> (+3.27%) ⬆️
...thentication/consumer/RSAConsumerTokenManager.java 77.41% <0.00%> (+6.45%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liubao68
Copy link
Contributor Author

re trigger ci

@liubao68 liubao68 closed this Oct 29, 2022
@liubao68 liubao68 reopened this Oct 29, 2022
@liubao68 liubao68 merged commit d03cff6 into apache:master Oct 29, 2022
lbc97 pushed a commit to lbc97/servicecomb-java-chassis that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants