Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2771]fix MicroserviceVersions concurrent access problem #3637

Merged
merged 1 commit into from
Feb 17, 2023
Merged

[SCB-2771]fix MicroserviceVersions concurrent access problem #3637

merged 1 commit into from
Feb 17, 2023

Conversation

liubao68
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@liubao68 liubao68 closed this Feb 17, 2023
@liubao68 liubao68 reopened this Feb 17, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3637 (736bfbd) into master (83cba93) will increase coverage by 0.01%.
The diff coverage is 47.36%.

❗ Current head 736bfbd differs from pull request most recent head 5e83579. Consider uploading reports for the commit 5e83579 to get more accurate results

@@             Coverage Diff              @@
##             master    #3637      +/-   ##
============================================
+ Coverage     42.87%   42.88%   +0.01%     
- Complexity     5966     5969       +3     
============================================
  Files          1554     1554              
  Lines         38817    38831      +14     
  Branches       3558     3561       +3     
============================================
+ Hits          16642    16654      +12     
- Misses        20885    20886       +1     
- Partials       1290     1291       +1     
Impacted Files Coverage Δ
...cecomb/registry/consumer/MicroserviceVersions.java 66.66% <37.50%> (+0.28%) ⬆️
...b/transport/rest/client/TransportClientConfig.java 83.33% <50.00%> (-4.91%) ⬇️
...est/client/Http2TransportHttpClientOptionsSPI.java 100.00% <100.00%> (ø)
...comb/core/definition/MicroserviceVersionsMeta.java 96.00% <0.00%> (-4.00%) ⬇️
...he/servicecomb/foundation/common/net/NetUtils.java 30.40% <0.00%> (+1.59%) ⬆️
.../servicecomb/registry/discovery/DiscoveryTree.java 80.32% <0.00%> (+3.27%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liubao68 liubao68 merged commit fe9ca22 into apache:master Feb 17, 2023
lbc97 pushed a commit to lbc97/servicecomb-java-chassis that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants