Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2773]Change mutil dicovery registry instance merge policy (#3650) #3651

Merged
merged 1 commit into from
Feb 21, 2023
Merged

[SCB-2773]Change mutil dicovery registry instance merge policy (#3650) #3651

merged 1 commit into from
Feb 21, 2023

Conversation

liubao68
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #3651 (7ecbac8) into 2.8.x (f87a75c) will increase coverage by 0.01%.
The diff coverage is 50.00%.

❗ Current head 7ecbac8 differs from pull request most recent head d2073ce. Consider uploading reports for the commit d2073ce to get more accurate results

@@             Coverage Diff              @@
##              2.8.x    #3651      +/-   ##
============================================
+ Coverage     74.38%   74.39%   +0.01%     
  Complexity      679      679              
============================================
  Files          1590     1590              
  Lines         39952    39953       +1     
  Branches       3655     3655              
============================================
+ Hits          29719    29724       +5     
+ Misses         8740     8738       -2     
+ Partials       1493     1491       -2     
Impacted Files Coverage Δ
...org/apache/servicecomb/registry/api/Discovery.java 0.00% <ø> (ø)
...stry/lightweight/AbstractLightweightDiscovery.java 0.00% <0.00%> (ø)
.../servicecomb/localregistry/LocalRegistryStore.java 92.45% <ø> (ø)
...e/servicecomb/schemadiscovery/SchemaDiscovery.java 53.65% <ø> (ø)
...cecomb/serviceregistry/ServiceCenterDiscovery.java 93.33% <ø> (ø)
...b/registry/api/registry/MicroserviceInstances.java 97.14% <66.66%> (-0.16%) ⬇️
.../apache/servicecomb/registry/DiscoveryManager.java 96.61% <100.00%> (+0.05%) ⬆️
...ache/servicecomb/localregistry/LocalDiscovery.java 85.71% <100.00%> (ø)
...mb/config/ConfigCenterConfigurationSourceImpl.java 10.63% <0.00%> (+1.06%) ⬆️
...he/servicecomb/foundation/common/net/NetUtils.java 66.40% <0.00%> (+1.60%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liubao68 liubao68 merged commit 5fc0561 into apache:2.8.x Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants