Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2794]process unknown parameters so that can compatible to old ve… #3800

Merged
merged 1 commit into from
May 20, 2023

Conversation

liubao68
Copy link
Contributor

…… (#3799)

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #3800 (597185d) into 2.8.x (c086c4c) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 597185d differs from pull request most recent head f6388bc. Consider uploading reports for the commit f6388bc to get more accurate results

@@             Coverage Diff              @@
##              2.8.x    #3800      +/-   ##
============================================
+ Coverage     74.42%   74.44%   +0.02%     
- Complexity      681      689       +8     
============================================
  Files          1591     1592       +1     
  Lines         39950    39982      +32     
  Branches       3650     3650              
============================================
+ Hits          29731    29763      +32     
- Misses         8730     8732       +2     
+ Partials       1489     1487       -2     
Impacted Files Coverage Δ
...o/springmvc/client/TestCompatible1xTestSchema.java 100.00% <100.00%> (ø)
...tion/arguments/AbstractArgumentsMapperCreator.java 98.61% <100.00%> (+0.08%) ⬆️
...ments/consumer/ConsumerArgumentsMapperCreator.java 98.14% <100.00%> (+0.07%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liubao68 liubao68 merged commit be3ab60 into apache:2.8.x May 20, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants