Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4004] fixed firstPull address choose logic #4034

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

chengyouling
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (8e174af) 74.18% compared to head (2b8157f) 74.15%.

❗ Current head 2b8157f differs from pull request most recent head 887c4c5. Consider uploading reports for the commit 887c4c5 to get more accurate results

Files Patch % Lines
...ervicecomb/config/kie/client/KieConfigManager.java 0.00% 26 Missing ⚠️
...mb/config/ConfigCenterConfigurationSourceImpl.java 0.00% 7 Missing ⚠️
...comb/config/center/client/ConfigCenterManager.java 0.00% 3 Missing ⚠️
...icecomb/config/kie/KieConfigurationSourceImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              2.8.x    #4034      +/-   ##
============================================
- Coverage     74.18%   74.15%   -0.03%     
  Complexity      707      707              
============================================
  Files          1598     1598              
  Lines         40239    40252      +13     
  Branches       3674     3675       +1     
============================================
- Hits          29850    29849       -1     
- Misses         8899     8914      +15     
+ Partials       1490     1489       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liubao68 liubao68 merged commit 7c95c9e into apache:2.8.x Nov 14, 2023
6 checks passed
@chengyouling chengyouling deleted the 2.8.x_fpull branch April 17, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants