Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4051]fix buffer reader not correct when length is 0 #4099

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

liubao68
Copy link
Contributor

@liubao68 liubao68 commented Dec 6, 2023

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3ccd557) 74.17% compared to head (9cf67e5) 74.17%.

❗ Current head 9cf67e5 differs from pull request most recent head 6dc253c. Consider uploading reports for the commit 6dc253c to get more accurate results

Files Patch % Lines
...omb/foundation/vertx/stream/BufferInputStream.java 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              2.8.x    #4099      +/-   ##
============================================
- Coverage     74.17%   74.17%   -0.01%     
  Complexity      707      707              
============================================
  Files          1594     1594              
  Lines         40142    40144       +2     
  Branches       3655     3656       +1     
============================================
- Hits          29777    29775       -2     
- Misses         8883     8886       +3     
- Partials       1482     1483       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liubao68 liubao68 merged commit 549024f into apache:2.8.x Dec 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants