Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2843]detect known configuration problems and send warning message #4137

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

liubao68
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (bfe03ae) 44.32% compared to head (e6ecd23) 44.33%.

❗ Current head e6ecd23 differs from pull request most recent head f07ba9a. Consider uploading reports for the commit f07ba9a to get more accurate results

Files Patch % Lines
...mb/core/bootup/ConfigurationProblemsCollector.java 48.78% 15 Missing and 6 partials ⚠️
...b/core/bootup/ConfigurationProblemsAlarmEvent.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4137   +/-   ##
=========================================
  Coverage     44.32%   44.33%           
- Complexity     5380     5390   +10     
=========================================
  Files          1382     1384    +2     
  Lines         34285    34331   +46     
  Branches       3320     3325    +5     
=========================================
+ Hits          15198    15219   +21     
- Misses        17855    17875   +20     
- Partials       1232     1237    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liubao68 liubao68 merged commit 1ee5a4d into apache:master Dec 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants