Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2845] Adding the switch to print response's buffer while failing to decode response body #4140

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

yanghao605
Copy link
Contributor

… to decode response body.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8a3a2a1) 74.28% compared to head (c62eaa5) 74.27%.

❗ Current head c62eaa5 differs from pull request most recent head e479ca6. Consider uploading reports for the commit e479ca6 to get more accurate results

Files Patch % Lines
...port/rest/client/http/DefaultHttpClientFilter.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              2.8.x    #4140      +/-   ##
============================================
- Coverage     74.28%   74.27%   -0.01%     
- Complexity      706      707       +1     
============================================
  Files          1596     1596              
  Lines         40235    40237       +2     
  Branches       3674     3675       +1     
============================================
- Hits          29890    29888       -2     
- Misses         8856     8857       +1     
- Partials       1489     1492       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yanghao605 yanghao605 changed the title [SCB-2797] Adding the switch to print response's buffer while failing to decode response body [SCB-2845] Adding the switch to print response's buffer while failing to decode response body Dec 18, 2023
@liubao68 liubao68 merged commit 3aa84eb into apache:2.8.x Dec 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants