Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2847]support configure default encoding for request and response #4167

Merged
merged 2 commits into from
Dec 26, 2023

Conversation

liubao68
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (f7e9a40) 44.33% compared to head (fee84a2) 44.33%.

❗ Current head fee84a2 differs from pull request most recent head 2188ad7. Consider uploading reports for the commit 2188ad7 to get more accurate results

Files Patch % Lines
.../common/rest/codec/param/BodyProcessorCreator.java 21.27% 36 Missing and 1 partial ⚠️
...on/rest/codec/produce/ProduceProcessorManager.java 27.27% 8 Missing ⚠️
...demo/jaxrs/client/MultiErrorCodeServiceClient.java 0.00% 2 Missing ⚠️
...dation/protobuf/internal/schema/SchemaManager.java 75.00% 2 Missing ⚠️
...ec/protobuf/utils/ScopedProtobufSchemaManager.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4167      +/-   ##
============================================
- Coverage     44.33%   44.33%   -0.01%     
+ Complexity     5392     5388       -4     
============================================
  Files          1384     1384              
  Lines         34331    34338       +7     
  Branches       3325     3326       +1     
============================================
+ Hits          15222    15223       +1     
- Misses        17874    17879       +5     
- Partials       1235     1236       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liubao68 liubao68 merged commit d484b5a into apache:master Dec 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants