Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4184] Router add some log for deal problem. #4185

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

chengyouling
Copy link
Contributor

No description provided.

@@ -58,7 +58,7 @@ public <T> List<T> getFilteredListOfServers(List<T> list,
PolicyRuleItem invokeRule = routerRuleMatcher.match(targetServiceName, extractor);

if (invokeRule == null) {
LOGGER.debug("route management match rule failed");
LOGGER.warn("route management hava no rule matched service {}", targetServiceName);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many logs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master@492b8d0). Click here to learn what that means.

❗ Current head b8d72e5 differs from pull request most recent head 2a4e6a8. Consider uploading reports for the commit 2a4e6a8 to get more accurate results

Files Patch % Lines
...ache/servicecomb/router/cache/RouterRuleCache.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4185   +/-   ##
=========================================
  Coverage          ?   44.39%           
  Complexity        ?     5398           
=========================================
  Files             ?     1382           
  Lines             ?    34341           
  Branches          ?     3326           
=========================================
  Hits              ?    15246           
  Misses            ?    17860           
  Partials          ?     1235           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liubao68 liubao68 merged commit c83e4fc into apache:master Jan 5, 2024
4 checks passed
@chengyouling chengyouling deleted the master-logs branch April 17, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants