Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2859]able to use wrapper class to serialize requests for primiti… #4227

Merged
merged 2 commits into from
Feb 4, 2024

Conversation

liubao68
Copy link
Contributor

@liubao68 liubao68 commented Feb 4, 2024

…ve types

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (ee301b3) 74.27% compared to head (e39863e) 74.24%.
Report is 1 commits behind head on 2.8.x.

❗ Current head e39863e differs from pull request most recent head 1ee788b. Consider uploading reports for the commit 1ee788b to get more accurate results

Files Patch % Lines
...ments/producer/ProducerArgumentsMapperCreator.java 27.77% 11 Missing and 2 partials ⚠️
.../springmvc/client/TestApiImplicitParamsSchema.java 82.85% 6 Missing ⚠️
...ger/generator/core/AbstractOperationGenerator.java 54.54% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              2.8.x    #4227      +/-   ##
============================================
- Coverage     74.27%   74.24%   -0.03%     
- Complexity      711      714       +3     
============================================
  Files          1598     1599       +1     
  Lines         40262    40317      +55     
  Branches       3677     3684       +7     
============================================
+ Hits          29903    29933      +30     
- Misses         8864     8887      +23     
- Partials       1495     1497       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liubao68 liubao68 merged commit c8499ef into apache:2.8.x Feb 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants