Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2862]able to upload with List form parameters #4235

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

liubao68
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f732e37) 44.65% compared to head (8069fc2) 44.72%.
Report is 2 commits behind head on master.

❗ Current head 8069fc2 differs from pull request most recent head 367a998. Consider uploading reports for the commit 367a998 to get more accurate results

Files Patch % Lines
.../common/rest/codec/param/FormProcessorCreator.java 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4235      +/-   ##
============================================
+ Coverage     44.65%   44.72%   +0.06%     
- Complexity     5432     5433       +1     
============================================
  Files          1385     1385              
  Lines         34387    34465      +78     
  Branches       3326     3332       +6     
============================================
+ Hits          15357    15415      +58     
- Misses        17789    17810      +21     
+ Partials       1241     1240       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liubao68 liubao68 merged commit eeacbec into apache:master Feb 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants