Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4237]Fix problems when scanning REST services with @RestController … #4238

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

liubao68
Copy link
Contributor

…annotation

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 44.73%. Comparing base (eeacbec) to head (cbb98b6).

❗ Current head cbb98b6 differs from pull request most recent head 705fa69. Consider uploading reports for the commit 705fa69 to get more accurate results

Files Patch % Lines
...a/org/apache/servicecomb/swagger/SwaggerUtils.java 0.00% 4 Missing ⚠️
...tation/RestControllerClassAnnotationProcessor.java 0.00% 2 Missing ⚠️
...agger/generator/core/AbstractSwaggerGenerator.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #4238      +/-   ##
============================================
+ Coverage     44.71%   44.73%   +0.01%     
- Complexity     5431     5433       +2     
============================================
  Files          1385     1385              
  Lines         34465    34466       +1     
  Branches       3332     3333       +1     
============================================
+ Hits          15412    15417       +5     
+ Misses        17811    17804       -7     
- Partials       1242     1245       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liubao68 liubao68 merged commit fe13d4e into apache:master Feb 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants