Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2864]upgrade vertx and fix connection pool problem and enable log activity #4262

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

liubao68
Copy link
Contributor

@liubao68 liubao68 commented Mar 7, 2024

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 74.24%. Comparing base (0fbed9a) to head (38a4256).

❗ Current head 38a4256 differs from pull request most recent head 6a5ec9c. Consider uploading reports for the commit 6a5ec9c to get more accurate results

Files Patch % Lines
...vicecomb/transport/rest/vertx/RestBodyHandler.java 0.00% 36 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              2.8.x    #4262      +/-   ##
============================================
- Coverage     74.24%   74.24%   -0.01%     
- Complexity      715      716       +1     
============================================
  Files          1599     1599              
  Lines         40370    40383      +13     
  Branches       3686     3689       +3     
============================================
+ Hits          29974    29981       +7     
- Misses         8899     8905       +6     
  Partials       1497     1497              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liubao68 liubao68 merged commit d38b9e9 into apache:2.8.x Mar 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants