Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2863]support zookeeper registry #4276

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Conversation

liubao68
Copy link
Contributor

@liubao68 liubao68 commented Apr 1, 2024

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.88%. Comparing base (1e90c2b) to head (c409a32).

❗ Current head c409a32 differs from pull request most recent head b6fea9c. Consider uploading reports for the commit b6fea9c to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4276   +/-   ##
=========================================
  Coverage     44.88%   44.88%           
  Complexity     5461     5461           
=========================================
  Files          1386     1386           
  Lines         34527    34527           
  Branches       3338     3338           
=========================================
  Hits          15496    15496           
  Misses        17781    17781           
  Partials       1250     1250           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liubao68 liubao68 merged commit 3b07b6e into apache:master Apr 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants